Skip to content

Add REL and SDBW map examples#112

Merged
skyelaird merged 1 commit intomainfrom
claude/add-map-examples-01AUqA6i9eWi5mAQ9F67VZ2J
Nov 17, 2025
Merged

Add REL and SDBW map examples#112
skyelaird merged 1 commit intomainfrom
claude/add-map-examples-01AUqA6i9eWi5mAQ9F67VZ2J

Conversation

@skyelaird
Copy link
Copy Markdown
Owner

Analyzed VOACAP reference maps from examples/ directory and identified key parameter discrepancies between VOACAP.com and DVOACAP-Python.

Key Findings:

  1. Missing bandwidth parameter - VOACAP uses mode-specific bandwidth (3/13/19/38 dB/Hz for WSPR/CW/FT8/SSB) but DVOACAP has no bandwidth parameter affecting noise calculations

  2. Required SNR default too high - Default 73.0 dB causes 0-1% reliability predictions when should be 20-100%. Solution: set to mode-specific values (10 dB for SSB, 6 dB for CW, -21 dB for FT8, -28 dB for WSPR)

  3. Antenna model differences - VOACAP uses HVD025.ANT @ -1° takeoff angle, DVOACAP uses generic models

  4. Noise specification differences - VOACAP shows -150 dBW, DVOACAP uses man_made_noise_at_3mhz = 145.0 dB above kTB

Files Added:

  • VOACAP_VALIDATION_FINDINGS.md: Comprehensive analysis document
  • test_voacap_validation.py: Initial validation test script
  • test_corrected_params.py: Demonstration of parameter corrections

Test Results:

  • With required_snr=73 (default): 0.0-1.2% reliability (broken)
  • With required_snr=10 (SSB): 82.9-95.4% reliability (realistic)
  • SNR predictions: 26.2-41.5 dB (matches expected range)

Priority recommendations:

  1. Add bandwidth parameter to VoacapParams
  2. Implement mode preset system
  3. Verify noise calculations vs VOACAP
  4. Add HVD025 antenna model

Reference: examples/FN74ui 2025.11.17-*.pdf maps

Description

A clear and concise description of what this PR does.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test coverage improvement

Related Issues

Closes #(issue number)
Related to #(issue number)

Changes Made

  • Change 1
  • Change 2
  • Change 3

Testing

Describe the tests you've run to verify your changes:

Test Configuration

  • Python version:
  • Operating System:
  • NumPy/SciPy versions:

Test Results

# Command used to test
python -m pytest tests/

# Or validation command
python test_voacap_reference.py
  • All existing tests pass
  • New tests added for new functionality
  • Validation pass rate maintained or improved
  • No performance regression

Validation Checklist

  • Code follows PEP 8 style guidelines
  • Docstrings added/updated for public functions
  • Type hints added where appropriate
  • Comments added for complex logic
  • Documentation updated (README, USAGE, etc.)
  • CHANGELOG.md updated
  • No new warnings or errors introduced

Performance Impact

  • No performance impact
  • Performance improved (provide benchmarks)
  • Minor performance regression (justified because...)
  • Not applicable

Benchmarks (if applicable)

Before: X seconds
After: Y seconds
Change: Z% improvement/regression

Breaking Changes

If this PR introduces breaking changes, describe:

  1. What breaks
  2. Migration path for users
  3. Why this change is necessary

Screenshots/Output (if applicable)

For dashboard changes or output format changes, include before/after screenshots or sample output.

Additional Notes

Any additional information that reviewers should know:

  • Assumptions made
  • Trade-offs considered
  • Future work needed
  • Dependencies added/removed

Reviewer Checklist

For maintainers reviewing this PR:

  • Code quality is acceptable
  • Tests are comprehensive
  • Documentation is clear
  • Validation results are acceptable
  • No security issues introduced
  • Backward compatibility maintained (or breaking changes justified)

Analyzed VOACAP reference maps from examples/ directory and identified
key parameter discrepancies between VOACAP.com and DVOACAP-Python.

Key Findings:
1. Missing bandwidth parameter - VOACAP uses mode-specific bandwidth
   (3/13/19/38 dB/Hz for WSPR/CW/FT8/SSB) but DVOACAP has no bandwidth
   parameter affecting noise calculations

2. Required SNR default too high - Default 73.0 dB causes 0-1% reliability
   predictions when should be 20-100%. Solution: set to mode-specific
   values (10 dB for SSB, 6 dB for CW, -21 dB for FT8, -28 dB for WSPR)

3. Antenna model differences - VOACAP uses HVD025.ANT @ -1° takeoff angle,
   DVOACAP uses generic models

4. Noise specification differences - VOACAP shows -150 dBW, DVOACAP uses
   man_made_noise_at_3mhz = 145.0 dB above kTB

Files Added:
- VOACAP_VALIDATION_FINDINGS.md: Comprehensive analysis document
- test_voacap_validation.py: Initial validation test script
- test_corrected_params.py: Demonstration of parameter corrections

Test Results:
- With required_snr=73 (default): 0.0-1.2% reliability (broken)
- With required_snr=10 (SSB): 82.9-95.4% reliability (realistic)
- SNR predictions: 26.2-41.5 dB (matches expected range)

Priority recommendations:
1. Add bandwidth parameter to VoacapParams
2. Implement mode preset system
3. Verify noise calculations vs VOACAP
4. Add HVD025 antenna model

Reference: examples/FN74ui 2025.11.17-*.pdf maps
@skyelaird skyelaird merged commit 0f07ea8 into main Nov 17, 2025
6 checks passed
skyelaird pushed a commit that referenced this pull request Nov 17, 2025
skyelaird pushed a commit that referenced this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants