SK-3004:Add Missing types & Update samples w.r.t flowDB support. - #714
Merged
Conversation
yaswanth-pula-skyflow
requested review from
saileshwar-skyflow and
skyflow-bharti
July 30, 2026 07:52
yaswanth-pula-skyflow
force-pushed
the
SK-3004/flowdb-samples
branch
from
July 30, 2026 08:19
f9670cc to
36d3a0c
Compare
saileshwar-skyflow
approved these changes
Jul 30, 2026
skyflow-bharti
approved these changes
Jul 30, 2026
yaswanth-pula-skyflow
added a commit
that referenced
this pull request
Jul 31, 2026
* SK-3004:Add Flowdb support for Collect & Reveal Elements. (#712) * SK-3004:Add flowdb implementation for collect & composable elements. * SK-3004:Add flowdb implementation for Reveal elements. * SK-3004:Update flowdb upsert options in collect options. * SK-3004:Update response & error parsing. * SK-3004:Update response & error parsing for reveal elements. * SK-3004:Update SkyflowID to SkyflowId. * SK-3004:Update Reveal response structure. * SK-3004:Update FlowDB support changes w.r.t latest contract. * SK-3004:Update & skip tests cases w.r.t privacyDB changes. * [AUTOMATED] Release - 2.7.9-dev.dc2ceeb * SK-3004:Add Missing types & Update samples w.r.t flowDB support. (#714) * SK-3004:Update README with flowdb changes. * SK-3004:Expose missing flowDB response types. * SK-3004:Update samples w.r.t flowDB changes. * SK-3004:Update upsert type table to tableName. * SK-3004:Update samples with SkyflowError type. * [AUTOMATED] Release - 2.7.9-dev.3e81d7f * SK-3004:Add mock cvv & tableName key update in collect elements. (#715) * SK-3004:Update table to tableName in Collect Element. * SK-3004:Add Mock CVV token support in collect elements. * SK-3004:Update samples with tableName key update. * [AUTOMATED] Release - 2.7.9-dev.fd11e15 * SK-3004:Update readme w.r.t flowDB changes. * SK-3004:Update readme w.r.t flowdb changes. --------- Co-authored-by: yaswanth-pula-skyflow <yaswanth-pula-skyflow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SK-3004: flowDB support — public response types + samples + Readme
Aligns the SDK's public TypeScript surface and all samples with the flowDB contract.
Expose missing flowDB response types (
bf86553)The flowDB request/options types were already public, but the response side still resolved to the old privacyDB shapes. This commit fixes that:
index-node.tsnow exports the flowDB response types —CollectResponse,CollectRecord,RevealResponse,RevealRecord— frominternal-types, replacing the stale V1 re-exports (CollectResponse/RevealResponsefromcommon, and the misaliasedIRevealRecord as RevealRecord).collect()/reveal()return types in the collect, compose-collect, and reveal containers to the flowDBCollectResponse/RevealResponse(composable-reveal inherits viaindex-node).SkyflowErrorclass;common.RevealResponse(V1) kept intact as the privacyDB path still uses it.npm run type-checkpasses.Update samples w.r.t flowDB changes (
cb20871)Migrated
using-npm,using-script-tag, andusing-typescriptsamples to the flowDB shapes:records[].tokens[column][0].token(wasrecords[0].fields).additionalFields.records[].{tableName, data, skyflowId}andupsert[].{table, uniqueColumns}; droppedtokens: true.redactionremoved and applied viareveal({ tokenGroupRedactions }).CollectOptions,AdditionalFields,AdditionalFieldsRecord,RevealOptions, …) and verified type-clean against the new types.Rename upsert option key
table→tableNameAligns the flowDB upsert option with
additionalFields.records[].tableNameso both collect-option objects use the same key for the table name.IFlowDBUpsertOptions.table→tableName(src/core-utils/collect.ts);getFlowDBUpsertForTablenow matches onupsertOption.tableName.validateUpsertOptions) and validation error messages (MISSING_/INVALID_TABLE_IN_UPSERT_OPTION) to referencetableName.upsert-support.htmlsample.