Skip to content

Fix input race causing tooltip flicker and unresponsive keyboard - #37

Merged
MisterGatto merged 1 commit into
skyprotocol:osp-masterfrom
HugeFrog24:osp-master
Aug 5, 2026
Merged

Fix input race causing tooltip flicker and unresponsive keyboard#37
MisterGatto merged 1 commit into
skyprotocol:osp-masterfrom
HugeFrog24:osp-master

Conversation

@HugeFrog24

Copy link
Copy Markdown
Contributor

Two bugs, one cause.

  1. Tooltips flickered every few seconds while a finger was held still, most obvious with Limit FPS on.
  2. Tapping a text field sometimes only moved the caret without opening the keyboard, until you tapped somewhere else first.

Both came down to Canvas touching ImGui from two threads at once, the render thread and the Android UI thread. Input from the UI thread is now buffered and replayed on the render thread, so ImGui state is only ever written from one place.

Verified against libSPT, libTSM and libtibik on a Galaxy A52 and a OnePlus 13: tooltips stable, keyboard reliable, scrolling smooth, existing mod behaviour unchanged.

Happy to expand on any of it.

Before / after

Tooltip flicker

Before:

flicker-before.mp4

After:

flicker-after.mp4

Keyboard not opening

Before:

keyboard-before.mp4

After:

keyboard-after.mp4

@MisterGatto
MisterGatto merged commit 94afc3c into skyprotocol:osp-master Aug 5, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants