Fix input race causing tooltip flicker and unresponsive keyboard - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs, one cause.
Both came down to Canvas touching ImGui from two threads at once, the render thread and the Android UI thread. Input from the UI thread is now buffered and replayed on the render thread, so ImGui state is only ever written from one place.
Verified against libSPT, libTSM and libtibik on a Galaxy A52 and a OnePlus 13: tooltips stable, keyboard reliable, scrolling smooth, existing mod behaviour unchanged.
Happy to expand on any of it.
Before / after
Tooltip flicker
Before:
flicker-before.mp4
After:
flicker-after.mp4
Keyboard not opening
Before:
keyboard-before.mp4
After:
keyboard-after.mp4