-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoints for calls.*
apis and Type: call
in blockkit
#1190
Conversation
Oddly, I have no idea why the lint step is failing. Downloaded and ran
Still no idea otherwise esp since master is passing, i'm fully based off of master, and all failing files are other ones I didn't touch here 😕. |
8916469
to
b0f1f5f
Compare
bump: @kanata2 is it possible to get a 👀 on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the awesome addition @winston-stripe ! I've left just a few minor items for you to review. I'm excited to get this merged and see what folks build with this.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
ack, finally have time to look back into this. Hopefully get it cleaned up again today. Thanks for the feedback @lorenzoaiello! |
@lorenzoaiello I updated the params + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the additions!
Implement the API methods for the Calls API in Slack https://api.slack.com/apis/calls
Implemented methods
calls.add
- Indicate a new call has been startedcalls.end
- Indicate to slack that the call has endedcalls.info
- Get information about an ongoing slack call objectcalls.update
- update call informationcalls.participants.add
calls.participants.remove
Additionally, I've added the minimal version of
Block{Type: "call", CallID: string}
which slack recommends/requires be posted back to the channel https://api.slack.com/apis/calls#post_to_channel.All implemented functionality is publicly documented. There appear to be additional attributes on the
type: call
block, however those appear to be internal values for slack's rendering, so I have left them out. See this gist for specific responses https://gist.github.com/winston-stripe/0cac608bd63b42d73a352be53577f7fdPull Request Guidelines
These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.
PR preparation
Run
make pr-prep
from the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
Examples of API changes that do not meet guidelines: