Skip to content

fix api ref repo#177

Merged
dblock merged 1 commit intomasterfrom
unknown repository
Nov 6, 2017
Merged

fix api ref repo#177
dblock merged 1 commit intomasterfrom
unknown repository

Conversation

@manuelmeurer
Copy link
Copy Markdown
Collaborator

@dangerpr-bot
Copy link
Copy Markdown

dangerpr-bot commented Nov 6, 2017

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Nov 6, 2017

See the Danger note above please, otherwise looks good.

@manuelmeurer
Copy link
Copy Markdown
Collaborator Author

manuelmeurer commented Nov 6, 2017

I updated the changelog after seeing the Danger note and force-pushed. Should it not check the updated commit again?
Edit - oops sorry, didn't read the error properly. 😄

@dblock dblock merged commit 9e6ea96 into slack-ruby:master Nov 6, 2017
@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Nov 6, 2017

Thanks!

@manuelmeurer manuelmeurer deleted the fix_api_ref_repo branch November 6, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants