Client stop method fails as the connected? method is a protected in Slack::RealTime::Concurrency::Celluloid::Socket class#40
Closed
kandadaboggu wants to merge 1 commit intoslack-ruby:masterfrom
workato:master
Closed
Client stop method fails as the connected? method is a protected in Slack::RealTime::Concurrency::Celluloid::Socket class#40kandadaboggu wants to merge 1 commit intoslack-ruby:masterfrom workato:master
kandadaboggu wants to merge 1 commit intoslack-ruby:masterfrom
workato:master
Conversation
Collaborator
|
Good point. This needs a test, please and an entry in https://github.com/dblock/slack-ruby-client/blob/master/CHANGELOG.md, please. |
Collaborator
|
Bump @kandadaboggu I tried to reproduce this, but I can't, the protected method is called from the same namespace and seems to work just fine as is. |
1 task
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the
connected?method public in Slack::RealTime::Concurrency::Celluloid::Socket