Merged
Conversation
Collaborator
|
This was brought up before in https://github.com/dblock/slack-ruby-client/pull/40. I'd like a spec that reproduces this problem, do you know how to make this happen? |
Contributor
Author
|
Yep. I have client that produces this, so I will try to write a minimal test case. |
Collaborator
|
I had tried to reproduce this without success. The integration tests in spec that run with a token could be a good place to start. |
mikz
force-pushed
the
celluloid-public-send
branch
from
dfb73b5 to
52bc868
Compare
Contributor
Author
|
@dblock done! |
Collaborator
|
So this has a fix, but CI has failed? So it didn't really fix it? |
Collaborator
|
Assuming you can figure the CI story out, this needs a CHANGELOG entry, please. |
Collaborator
|
Oh duh it's just Rubocop. Fix the build, add to CHANGELOG and it's good to go. Thanks! |
``` E, [2016-01-18T18:58:44.358004 #48656] ERROR -- : Actor crashed! NoMethodError: protected method `connected?' called for #<Slack::RealTime::Concurrency::Celluloid::Socket:0x007f8d73c5f3c0> /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/calls.rb:28:in `public_send' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/calls.rb:28:in `dispatch' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/call/sync.rb:16:in `dispatch' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/cell.rb:50:in `block in dispatch' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/cell.rb:76:in `block in task' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/actor.rb:339:in `block in task' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/task.rb:44:in `block in initialize' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/task/fibered.rb:14:in `block in create' [2016-01-18 18:58:44] ERROR NoMethodError: protected method `connected?' called for #<Slack::RealTime::Concurrency::Celluloid::Socket:0x007f8d73c5f3c0> /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/calls.rb:28:in `public_send' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/calls.rb:28:in `dispatch' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/call/sync.rb:16:in `dispatch' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/cell.rb:50:in `block in dispatch' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/cell.rb:76:in `block in task' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/actor.rb:339:in `block in task' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/task.rb:44:in `block in initialize' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/task/fibered.rb:14:in `block in create' (celluloid):0:in `remote procedure call' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/call/sync.rb:45:in `value' /Users/user/.rvm/gems/ruby-2.2.4/gems/celluloid-0.17.2/lib/celluloid/proxy/sync.rb:38:in `method_missing' /Users/user/.rvm/gems/ruby-2.2.4/gems/slack-ruby-client-0.5.3/lib/slack/real_time/client.rb:56:in `started?' /Users/user/.rvm/gems/ruby-2.2.4/gems/slack-ruby-client-0.5.3/lib/slack/real_time/client.rb:114:in `send_json' /Users/user/.rvm/gems/ruby-2.2.4/gems/slack-ruby-client-0.5.3/lib/slack/real_time/api/message.rb:15:in `message' ```
mikz
force-pushed
the
celluloid-public-send
branch
from
52bc868 to
cf89021
Compare
Contributor
Author
|
Looks like the build fails because it expects messages on the same channel, when running in parallel. |
Collaborator
|
That's an interesting failure. Should probably fix this to just wait for a message that we expect instead of checking that the message received is exactly the message we expect. Can do this later, I'm going to try to kick this build into passing just to confirm something is not permanently broken. |
dblock
added a commit
that referenced
this pull request
Jan 22, 2016
[celluloid] fix call on protected method
Collaborator
|
Merged, thanks for seeing this through. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #40
so move the
#connected?to publicTODO