Add more information to unhandled incoming request logging#1143
Merged
misscoded merged 3 commits intoslackapi:mainfrom Oct 8, 2021
Merged
Add more information to unhandled incoming request logging#1143misscoded merged 3 commits intoslackapi:mainfrom
misscoded merged 3 commits intoslackapi:mainfrom
Conversation
10 tasks
Codecov Report
@@ Coverage Diff @@
## main #1143 +/- ##
=======================================
Coverage 71.71% 71.71%
=======================================
Files 15 15
Lines 1354 1354
Branches 402 402
=======================================
Hits 971 971
Misses 312 312
Partials 71 71
Continue to review full report at Codecov.
|
seratch
approved these changes
Oct 5, 2021
Contributor
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Nice improvement as the first step!
To make the logging by the server consistent, we may want to add the method/path information to the error logging in L242 too.
10 tasks
misscoded
force-pushed
the
improve-unhandled-req-info
branch
from
1a9b811 to
c06e138
Compare
stevengill
approved these changes
Oct 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #1138.
This PR adds more information about incoming unhandled requests, specifically the method and endpoint (similar to the information offered when errors are thrown). This should save developers time when debugging cases where there's a mismatch in endpoints compared to the Request URLs in the app configuration.
Previous:
[INFO] An unhandled request was ignoredWith change:
[INFO] Unhandled HTTP request (POST) made to /slack/bad-endpointRequirements (place an
xin each[ ])