Skip to content

Fix #1141 state is missing in the block_action payload type#1144

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-1141-state-in-action
Oct 6, 2021
Merged

Fix #1141 state is missing in the block_action payload type#1144
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-1141-state-in-action

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Oct 5, 2021

Summary

This pull request fixes #1141. Refer to the issue for more details.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Oct 5, 2021
@seratch seratch added this to the 3.8.0 milestone Oct 5, 2021
@seratch seratch requested a review from mwbrooks October 5, 2021 12:24
@seratch seratch self-assigned this Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #1144 (a062bd8) into main (91037be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1144   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files          15       15           
  Lines        1354     1354           
  Branches      402      402           
=======================================
  Hits          971      971           
  Misses        312      312           
  Partials       71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91037be...a062bd8. Read the comment docs.

@seratch seratch merged commit a24e3b8 into slackapi:main Oct 6, 2021
@seratch seratch deleted the issue-1141-state-in-action branch October 6, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BlockAction interface does not include state despite state being present in actual object

2 participants