Improve App initialization error logs + docs#1250
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1250 +/- ##
=======================================
Coverage 73.22% 73.22%
=======================================
Files 17 17
Lines 1438 1438
Branches 431 431
=======================================
Hits 1053 1053
Misses 300 300
Partials 85 85
Continue to review full report at Codecov.
|
seratch
left a comment
There was a problem hiding this comment.
Left one comment about the change on the boolean test part. All other changes sound great 👍
| * `clientId`, `clientSecret`, `stateSecret` and `scopes` (required) | ||
| * An `installationStore` option with `storeInstallation` and `fetchInstallation` handlers defined for storing installation data to a database *(optional, but highly recommended for production)* |
There was a problem hiding this comment.
Nice improvement on clarity. I always appreciate when arguments are explicitly "required" or "optional"
filmaj
left a comment
There was a problem hiding this comment.
Sorry I'm late to the party here! Agree with the comments here, there are a few small tweaks left to some of the wording and error messaging that would improve this PR. That being said, thanks for putting the time into making these changes - already a huge improvement over what was there before!
796ca8e to
990cd48
Compare
Summary
Appinitialization error case loggingTest
Requirements (place an
xin each[ ])