Skip to content

Export more message event types#1254

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:export-message-event-types
Jan 4, 2022
Merged

Export more message event types#1254
seratch merged 1 commit intoslackapi:mainfrom
seratch:export-message-event-types

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Dec 22, 2021

Summary

This pull request adds a few missing message subtype events to exports.

See #832 (comment) for the context.

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality TypeScript-specific labels Dec 22, 2021
@seratch seratch added this to the 3.9.0 milestone Dec 22, 2021
@seratch seratch self-assigned this Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #1254 (70ee8e1) into main (0f3e40c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1254   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          17       17           
  Lines        1438     1438           
  Branches      431      431           
=======================================
  Hits         1053     1053           
  Misses        300      300           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f3e40c...70ee8e1. Read the comment docs.

Copy link

@jestrada jestrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help clean up some code on my end. Thanks for the speedy response!

@seratch seratch merged commit 75d4ca2 into slackapi:main Jan 4, 2022
@seratch seratch deleted the export-message-event-types branch January 4, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality TypeScript-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants