Skip to content

Fix node types#1607

Merged
srajiang merged 2 commits intomainfrom
fix-node-types
Sep 26, 2022
Merged

Fix node types#1607
srajiang merged 2 commits intomainfrom
fix-node-types

Conversation

@srajiang
Copy link
Contributor

Summary

Fixes type errors raised when @types/node >18.7.15 version in place and updates to latest supported 18.7.22.

Requirements (place an x in each [ ])

@srajiang srajiang self-assigned this Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #1607 (e957aa9) into main (690be0f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1607   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files          18       18           
  Lines        1496     1496           
  Branches      436      436           
=======================================
  Hits         1227     1227           
  Misses        172      172           
  Partials       97       97           
Impacted Files Coverage Δ
src/receivers/ExpressReceiver.ts 88.70% <100.00%> (ø)
src/receivers/HTTPReceiver.ts 56.60% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srajiang srajiang merged commit 4ec194b into main Sep 26, 2022
@srajiang srajiang deleted the fix-node-types branch September 26, 2022 17:07
@srajiang srajiang added enhancement M-T: A feature request for new functionality semver:minor and removed semver:minor labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants