feat(receivers): add invalidRequestSignatureHandler to HTTP/Express receivers#2937
Open
singhvishalkr wants to merge 1 commit into
Open
feat(receivers): add invalidRequestSignatureHandler to HTTP/Express receivers#2937singhvishalkr wants to merge 1 commit into
singhvishalkr wants to merge 1 commit into
Conversation
…eceivers Adds an optional callback that fires when request signature verification fails. This mirrors the existing behavior in AwsLambdaReceiver, letting developers add custom logging, metrics, or alerting when invalid signatures are detected. Fixes slackapi#2156
|
|
Thanks for the contribution! Before we can merge this, we need @singhvishalkr to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an invalidRequestSignatureHandler option to HTTPReceiver and ExpressReceiver, mirroring the existing functionality in AwsLambdaReceiver from PR #2154.
When a request fails signature verification, this handler fires before the 401 response is sent. It receives the signature, timestamp, body, request, and response objects so developers can add custom logging, metrics collection, or alerting.
Changes
Test plan
Fixes #2156