Fix #348 app.view() is not described in the README#410
Merged
stevengill merged 2 commits intoslackapi:masterfrom Feb 18, 2020
Merged
Fix #348 app.view() is not described in the README#410stevengill merged 2 commits intoslackapi:masterfrom
stevengill merged 2 commits intoslackapi:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 7 7
Lines 525 525
Branches 150 150
=======================================
Hits 427 427
Misses 70 70
Partials 28 28Continue to review full report at Codecov.
|
shaydewael
approved these changes
Feb 18, 2020
stevengill
approved these changes
Feb 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #348 by adding the explanation about
app.viewhandlers on README.In addition, I wanted to propose having another example of
app.actionwith callback_id patterns. Referring to this table may be helpful to understand the whole.There is one more task related to this.
@slack/bolt@nextbranchRequirements (place an
xin each[ ])