Skip to content

Fix #436 View type missing optional id from response#437

Merged
stevengill merged 1 commit intoslackapi:masterfrom
seratch:issue-436
Mar 24, 2020
Merged

Fix #436 View type missing optional id from response#437
stevengill merged 1 commit intoslackapi:masterfrom
seratch:issue-436

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Mar 24, 2020

Summary

This pull request fixes #436 by changing the type definition of block_actions payloads.

Requirements (place an x in each [ ])

@seratch seratch requested review from aoberoi and stevengill March 24, 2020 08:43
@seratch seratch self-assigned this Mar 24, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2020

Codecov Report

Merging #437 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   79.77%   79.77%           
=======================================
  Files           7        7           
  Lines         544      544           
  Branches      158      158           
=======================================
  Hits          434      434           
  Misses         80       80           
  Partials       30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df7d37...e4f1728. Read the comment docs.

@seratch seratch added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label Mar 24, 2020
@stevengill stevengill merged commit 51a527d into slackapi:master Mar 24, 2020
@seratch seratch deleted the issue-436 branch March 24, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View type missing optional id from response

3 participants