ci: send regression notifications if tests for code coverage error#1496
ci: send regression notifications if tests for code coverage error#1496zimeg wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 228 228
Lines 7262 7262
=======================================
Hits 6632 6632
Misses 630 630 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
left a comment
There was a problem hiding this comment.
I'm not sure we should merge this 🤔
From what I understand the regression notification aren't depended on the codecov uploading, if the tests fail in the codecov that means there is some flakiness in our unittests, but I don't think we want to get notified when there is CodeCov infrastructure issue
|
PR #1497 aims to improve the stability of the unit tests around mocking the global time 🤔 I think this should resolve our issue, let me know what you think 🙏 |
|
@WilliamBergamin Ah I was taking the investigations into unit tests a bit slower 😉 Your approach is perhaps what I was hoping for with these changes so I'll close this PR! |
Summary
This PR adds the "codecov" job to lists of what regression notifications are sent for 📣
Testing
Let's hope to not find out! But earlier workflows erroring appear as:
🔗 https://github.com/slackapi/bolt-python/actions/runs/25383886159/job/74439411695
Category
Notes
mainto be confusing without having seen a notification in channel 🙏 ✨Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.