Skip to content

Conversation

@siegerts
Copy link
Contributor

(Describe the goal of this PR. Mention any related Issue numbers)

  • chore(lazy_listener.md): minor typo fix

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@CLAassistant
Copy link

CLAassistant commented May 12, 2021

CLA assistant check
All committers have signed the CLA.

@seratch seratch self-assigned this May 12, 2021
@seratch seratch added the docs Improvements or additions to documentation label May 12, 2021
@seratch seratch added this to the 1.6.1 milestone May 12, 2021
@seratch
Copy link
Contributor

seratch commented May 12, 2021

Hi @siegerts, thanks for taking the time to send this PR! The change looks good to me but would you mind signing our CLA? https://cla-assistant.io/slackapi/bolt-python?pullRequest=338

@seratch
Copy link
Contributor

seratch commented May 12, 2021

@siegerts Thanks for signing the CLA! I will merge this PR once the CI builds successfully pass.

@seratch
Copy link
Contributor

seratch commented May 12, 2021

The tests for Socket Mode adapters are failing for some reason in GitHub Actions but obviously it's unrelated to this change. Let me merge this PR now. Thanks again!

@seratch seratch closed this May 12, 2021
@seratch seratch reopened this May 12, 2021
@seratch seratch merged commit 1400f64 into slackapi:main May 12, 2021
@siegerts siegerts deleted the lazy-listener-typo branch May 12, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants