Fix #61 by correcting payload in middleware/listener args#63
Merged
seratch merged 2 commits intoslackapi:mainfrom Sep 5, 2020
Merged
Fix #61 by correcting payload in middleware/listener args#63seratch merged 2 commits intoslackapi:mainfrom
seratch merged 2 commits intoslackapi:mainfrom
Conversation
mwbrooks
approved these changes
Sep 4, 2020
Member
mwbrooks
left a comment
There was a problem hiding this comment.
All tests pass ./scripts/run_tests.sh and nothing jumped out at me while reading through the changes.
This a huge refactor that touches a lot of code. As long as you're confident about the test coverage, then I think it's good to go!
Contributor
Author
|
Thank you for checking this! Yes, as we already have lots of unit tests including the ones for adapters, I'm sure that the changes do not break anything (actually in the development process, the tests helped me detect a lot of errors) |
Contributor
Author
|
Also, I verified the changes not only by running tests but manually making sure if the samples work. |
Contributor
Author
|
Ah, I noticed that a few samples need to be updated. I will do that before merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #61 by correcting the definitions of
bodyandpayloadin middleware/listener args.Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapterRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/run_tests.shafter making the changes.