Skip to content

Fix #61 by correcting payload in middleware/listener args#63

Merged
seratch merged 2 commits intoslackapi:mainfrom
seratch:issue-61-payload-body
Sep 5, 2020
Merged

Fix #61 by correcting payload in middleware/listener args#63
seratch merged 2 commits intoslackapi:mainfrom
seratch:issue-61-payload-body

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Sep 4, 2020

This pull request fixes #61 by correcting the definitions of body and payload in middleware/listener args.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:async area:sync labels Sep 4, 2020
@seratch seratch added this to the 0.4.0a0 milestone Sep 4, 2020
@seratch seratch self-assigned this Sep 4, 2020
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass ./scripts/run_tests.sh and nothing jumped out at me while reading through the changes.

This a huge refactor that touches a lot of code. As long as you're confident about the test coverage, then I think it's good to go!

@seratch
Copy link
Contributor Author

seratch commented Sep 4, 2020

Thank you for checking this! Yes, as we already have lots of unit tests including the ones for adapters, I'm sure that the changes do not break anything (actually in the development process, the tests helped me detect a lot of errors)

@seratch
Copy link
Contributor Author

seratch commented Sep 4, 2020

Also, I verified the changes not only by running tests but manually making sure if the samples work.

@seratch
Copy link
Contributor Author

seratch commented Sep 4, 2020

Ah, I noticed that a few samples need to be updated. I will do that before merging this.

@seratch seratch merged commit d2a6e36 into slackapi:main Sep 5, 2020
@seratch seratch deleted the issue-61-payload-body branch September 5, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:async area:sync bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

payload != body in middleware/listener args

2 participants