Skip to content

Correct javadoc for GoodbyeEvent - #691

Merged
seratch merged 1 commit into
slackapi:mainfrom
KingBuzzer:fix-goodbyeevent-javadoc
Feb 17, 2021
Merged

Correct javadoc for GoodbyeEvent#691
seratch merged 1 commit into
slackapi:mainfrom
KingBuzzer:fix-goodbyeevent-javadoc

Conversation

@KingBuzzer

Copy link
Copy Markdown
Contributor

Correct javadoc for the GoodbyeEvent

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@gitwave gitwave Bot added the untriaged label Feb 17, 2021
@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented docs M-T: Documentation work only project:slack-api-model project:slack-api-model and removed untriaged labels Feb 17, 2021
@seratch seratch added this to the 1.6.2 milestone Feb 17, 2021

@seratch seratch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@seratch

seratch commented Feb 17, 2021

Copy link
Copy Markdown
Contributor

Some tests are failing but this change is unrelated. It's safe enough to merge this (I will look at the occasional test failure)

Running test_locally.SocketModeAppTest
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.985 sec <<< FAILURE!
payloadHandling(test_locally.SocketModeAppTest)  Time elapsed: 2.181 sec  <<< FAILURE!
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at test_locally.SocketModeAppTest.payloadHandling(SocketModeAppTest.java:73)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented docs M-T: Documentation work only project:slack-api-model project:slack-api-model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants