Skip to content

Maven duplicates removals - #695

Merged
seratch merged 7 commits into
slackapi:mainfrom
KingBuzzer:maven-duplicates-removals
Feb 25, 2021
Merged

Maven duplicates removals#695
seratch merged 7 commits into
slackapi:mainfrom
KingBuzzer:maven-duplicates-removals

Conversation

@KingBuzzer

Copy link
Copy Markdown
Contributor

Remove some duplicate dependency declarations, some which produce build warnings.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch

seratch commented Feb 25, 2021

Copy link
Copy Markdown
Contributor

Thanks for improving the build settings! We'll merge this once we've confirmed all the tests pass.

@codecov

codecov Bot commented Feb 25, 2021

Copy link
Copy Markdown

Codecov Report

Merging #695 (3671993) into main (2146481) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #695      +/-   ##
============================================
- Coverage     77.31%   77.28%   -0.04%     
+ Complexity     3222     3221       -1     
============================================
  Files           360      360              
  Lines          9539     9539              
  Branches        913      913              
============================================
- Hits           7375     7372       -3     
- Misses         1622     1624       +2     
- Partials        542      543       +1     
Impacted Files Coverage Δ Complexity Δ
...va/com/slack/api/socket_mode/SocketModeClient.java 67.76% <0.00%> (-1.98%) 37.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 330bb33...3671993. Read the comment docs.

@seratch

seratch commented Feb 25, 2021

Copy link
Copy Markdown
Contributor

Thanks a lot for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants