Skip to content

Add the browser version URL in OAuth completion page - #702

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:browser-version-link
Mar 4, 2021
Merged

Add the browser version URL in OAuth completion page#702
seratch merged 1 commit into
slackapi:mainfrom
seratch:browser-version-link

Conversation

@seratch

@seratch seratch commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

This pull request brings slackapi/python-slack-sdk#963 improvements to Bolt for Java. This is just an improvement on the default page rendering. If an app serves its own web pages, this change does not affect the app.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt labels Mar 4, 2021
@seratch seratch added this to the 1.6.3 milestone Mar 4, 2021
@seratch
seratch requested review from mwbrooks and stevengill March 4, 2021 09:33
@codecov

codecov Bot commented Mar 4, 2021

Copy link
Copy Markdown

Codecov Report

Merging #702 (b53911f) into main (1208c2a) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #702   +/-   ##
=========================================
  Coverage     77.32%   77.33%           
  Complexity     3225     3225           
=========================================
  Files           361      361           
  Lines          9543     9546    +3     
  Branches        913      913           
=========================================
+ Hits           7379     7382    +3     
  Misses         1622     1622           
  Partials        542      542           
Impacted Files Coverage Δ Complexity Δ
...ault_impl/OAuthDefaultRedirectUriPageRenderer.java 42.10% <75.00%> (+10.85%) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1208c2a...2d78479. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:bolt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants