Fix #698 Check fallback in attachments for missing fallback text warning - #707
Merged
Merged
Conversation
seratch
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #707 +/- ##
============================================
+ Coverage 77.06% 77.17% +0.11%
- Complexity 3235 3245 +10
============================================
Files 363 363
Lines 9627 9656 +29
Branches 918 923 +5
============================================
+ Hits 7419 7452 +33
+ Misses 1661 1658 -3
+ Partials 547 546 -1
Continue to review full report at Codecov.
|
seratch
force-pushed
the
issue-698-fallback-warning
branch
from
March 15, 2021 02:16
496d09d to
8cfc6e2
Compare
mwbrooks
approved these changes
Mar 15, 2021
mwbrooks
left a comment
mwbrooks
left a comment
Member
There was a problem hiding this comment.
Looks good to me and tests pass on my local system!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #698 by adding a new validation that verifies the existence of fallback field in attachments in a message.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.