Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Jul 14, 2022

This pull request resolves #1019

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model labels Jul 14, 2022
@seratch seratch added this to the 1.24.0 milestone Jul 14, 2022
@seratch seratch self-assigned this Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1020 (d477b05) into main (ff84898) will decrease coverage by 0.03%.
The diff coverage is 68.57%.

@@             Coverage Diff              @@
##               main    #1020      +/-   ##
============================================
- Coverage     76.70%   76.66%   -0.04%     
- Complexity     3689     3697       +8     
============================================
  Files           403      406       +3     
  Lines         11121    11156      +35     
  Branches       1111     1111              
============================================
+ Hits           8530     8553      +23     
- Misses         1921     1932      +11     
- Partials        670      671       +1     
Impacted Files Coverage Δ
...model/kotlin_extension/block/dsl/LayoutBlockDsl.kt 33.33% <ø> (ø)
...rc/main/java/com/slack/api/model/block/Blocks.java 94.44% <0.00%> (-5.56%) ⬇️
...ension/block/composition/dsl/PlainTextObjectDsl.kt 33.33% <33.33%> (ø)
.../model/kotlin_extension/block/VideoBlockBuilder.kt 69.23% <69.23%> (ø)
...sition/container/SinglePlainTextObjectContainer.kt 100.00% <100.00%> (ø)
...nsion/block/container/MultiLayoutBlockContainer.kt 95.00% <100.00%> (+0.26%) ⬆️
...om/slack/api/util/json/GsonLayoutBlockFactory.java 80.76% <100.00%> (+0.76%) ⬆️
...imits/metrics/impl/BaseMemoryMetricsDatastore.java 79.65% <0.00%> (-0.44%) ⬇️
...va/com/slack/api/socket_mode/SocketModeClient.java 64.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff84898...d477b05. Read the comment docs.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@seratch seratch merged commit 1f283a1 into slackapi:main Jul 14, 2022
@seratch seratch deleted the issue-1019-video-blocks branch July 14, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add video block to Block Kit support

2 participants