-
Notifications
You must be signed in to change notification settings - Fork 228
Improved readability of tests #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Improved the readability of newly created test to facilitate the understanding of http status codes in tests
seratch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Can you make the constants static?
bolt-jakarta-servlet/src/test/java/test_locally/servlet_test/InvalidRequestPatternTest.java
Outdated
Show resolved
Hide resolved
bolt-jakarta-servlet/src/test/java/test_locally/servlet_test/SlashCommandTest.java
Outdated
Show resolved
Hide resolved
bolt-servlet/src/test/java/test_locally/servlet_test/InvalidRequestPatternTest.java
Outdated
Show resolved
Hide resolved
bolt-servlet/src/test/java/test_locally/servlet_test/SlashCommandTest.java
Outdated
Show resolved
Hide resolved
bolt/src/test/java/test_locally/app/InvalidPayloadPatternTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1025 +/- ##
=========================================
Coverage 76.78% 76.79%
- Complexity 3705 3706 +1
=========================================
Files 406 406
Lines 11159 11159
Branches 1112 1112
=========================================
+ Hits 8568 8569 +1
Misses 1921 1921
+ Partials 670 669 -1
Continue to review full report at Codecov.
|
Improved the readability of newly created test to:
I don't know if we want to implement this for every test in the library, maybe someone can comment on this?
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.