Skip to content

Conversation

@WilliamBergamin
Copy link
Contributor

Improved the readability of newly created test to:

  • facilitate the understanding of http status codes in tests
  • ensure that content types and other web standards are maintained

I don't know if we want to implement this for every test in the library, maybe someone can comment on this?

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

Improved the readability of newly created test to facilitate the understanding of http status codes in tests
Copy link
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Can you make the constants static?

@seratch seratch added this to the 1.24.1 milestone Jul 15, 2022
@seratch seratch added the enhancement M-T: A feature request for new functionality label Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1025 (731976d) into main (6b8fc68) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1025   +/-   ##
=========================================
  Coverage     76.78%   76.79%           
- Complexity     3705     3706    +1     
=========================================
  Files           406      406           
  Lines         11159    11159           
  Branches       1112     1112           
=========================================
+ Hits           8568     8569    +1     
  Misses         1921     1921           
+ Partials        670      669    -1     
Impacted Files Coverage Δ
...imits/metrics/impl/BaseMemoryMetricsDatastore.java 80.08% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8fc68...731976d. Read the comment docs.

@seratch seratch merged commit 9c2c18c into main Jul 19, 2022
@seratch seratch deleted the improving-readability-of-tests branch July 19, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:bolt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants