Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Sep 15, 2022

This pull request adds a new block that can be posted by the next-generation platform's link triggers. Although the next-gen features are still in beta, developers may need to parse those blocks in conversations.history/Discovery API response data and so on if they exist.

We need to add the same in other SDKs.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model labels Sep 15, 2022
@seratch seratch added this to the 1.25.2 milestone Sep 15, 2022
@seratch seratch self-assigned this Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1047 (54ae5e6) into main (037bceb) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##               main    #1047   +/-   ##
=========================================
  Coverage     76.78%   76.78%           
- Complexity     3705     3707    +2     
=========================================
  Files           406      406           
  Lines         11161    11163    +2     
  Branches       1112     1112           
=========================================
+ Hits           8570     8572    +2     
  Misses         1921     1921           
  Partials        670      670           
Impacted Files Coverage Δ
...rc/main/java/com/slack/api/model/block/Blocks.java 89.47% <0.00%> (-4.98%) ⬇️
...om/slack/api/util/json/GsonLayoutBlockFactory.java 81.48% <100.00%> (+0.71%) ⬆️
...va/com/slack/api/socket_mode/SocketModeClient.java 64.33% <0.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 💯 where the samples generated?

@seratch
Copy link
Contributor Author

seratch commented Sep 15, 2022

@WilliamBergamin Good question. Those JSON data are automatically updated when running all the unit and e2e tests.

@seratch seratch merged commit e9a0516 into slackapi:main Sep 15, 2022
@seratch seratch deleted the nextgen-blocks branch September 15, 2022 21:17
seratch added a commit that referenced this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants