Skip to content

Conversation

@jasonoh
Copy link
Contributor

@jasonoh jasonoh commented Oct 19, 2022

This is a single, minor spelling fix. No code changes.

Category (place an x in each of the [ ])

  • [x ] bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@srajiang srajiang added the docs M-T: Documentation work only label Oct 19, 2022
@srajiang srajiang self-requested a review October 19, 2022 20:46
Copy link
Contributor

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix @jasonoh!

@jasonoh
Copy link
Contributor Author

jasonoh commented Oct 19, 2022

my pleasure, @srajiang! 😄

@srajiang srajiang added this to the 1.26.2 milestone Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1073 (de1db1d) into main (3cfdea5) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head de1db1d differs from pull request most recent head b54d092. Consider uploading reports for the commit b54d092 to get more accurate results

@@             Coverage Diff              @@
##               main    #1073      +/-   ##
============================================
+ Coverage     76.74%   76.76%   +0.01%     
- Complexity     3761     3763       +2     
============================================
  Files           409      409              
  Lines         11402    11402              
  Branches       1150     1150              
============================================
+ Hits           8751     8753       +2     
+ Misses         1961     1960       -1     
+ Partials        690      689       -1     
Impacted Files Coverage Δ
...imits/metrics/impl/BaseMemoryMetricsDatastore.java 80.08% <0.00%> (+0.43%) ⬆️
...va/com/slack/api/socket_mode/SocketModeClient.java 64.33% <0.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srajiang srajiang merged commit b9841e3 into slackapi:main Oct 19, 2022
seratch added a commit that referenced this pull request Oct 19, 2022
@seratch seratch modified the milestones: 1.26.2, 1.27.0 Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants