Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Feb 6, 2023

This pull request resolves #1082

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model labels Feb 6, 2023
@seratch seratch added this to the 1.27.4 milestone Feb 6, 2023
@seratch seratch self-assigned this Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1117 (ba0e1d4) into main (df4a4fb) will decrease coverage by 0.05%.
The diff coverage is 65.71%.

@@             Coverage Diff              @@
##               main    #1117      +/-   ##
============================================
- Coverage     75.75%   75.70%   -0.05%     
- Complexity     3796     3809      +13     
============================================
  Files           414      414              
  Lines         11829    11864      +35     
  Branches       1168     1174       +6     
============================================
+ Hits           8961     8982      +21     
- Misses         2165     2172       +7     
- Partials        703      710       +7     
Impacted Files Coverage Δ
.../java/com/slack/api/methods/MethodsRateLimits.java 99.06% <ø> (ø)
...java/com/slack/api/methods/RequestFormBuilder.java 87.56% <47.82%> (-0.60%) ⬇️
...slack/api/methods/impl/AsyncMethodsClientImpl.java 93.14% <100.00%> (+0.09%) ⬆️
.../com/slack/api/methods/impl/MethodsClientImpl.java 83.64% <100.00%> (+0.12%) ⬆️
...va/com/slack/api/socket_mode/SocketModeClient.java 67.51% <0.00%> (-0.64%) ⬇️
...imits/metrics/impl/BaseMemoryMetricsDatastore.java 79.65% <0.00%> (-0.44%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit ac9640f into slackapi:main Feb 6, 2023
@seratch seratch deleted the issue-1082-admin-roles-api branch February 6, 2023 21:25
@seratch seratch modified the milestones: 1.27.4, 1.28.0 Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add admin.roles.{list|add|remove}Assignments API supports

1 participant