Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Mar 8, 2023

This pull request fixes the issue originally reported for bolt-python. Refer to slackapi/bolt-python#844 for the equivalent changes in Python.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:bolt labels Mar 8, 2023
@seratch seratch added this to the 1.28.0 milestone Mar 8, 2023
@seratch seratch self-assigned this Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1126 (8f035c8) into main (1d54ca0) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1126   +/-   ##
=========================================
  Coverage     75.75%   75.76%           
- Complexity     3812     3813    +1     
=========================================
  Files           414      414           
  Lines         11866    11866           
  Branches       1174     1174           
=========================================
+ Hits           8989     8990    +1     
+ Misses         2172     2171    -1     
  Partials        705      705           
Impacted Files Coverage Δ
...va/com/slack/api/socket_mode/SocketModeClient.java 64.33% <0.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 6dfd760 into slackapi:main Mar 8, 2023
@seratch seratch deleted the respond-thread-ts branch March 8, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:bolt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant