Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Nov 13, 2023

This pull request resolves #1233 for the main branch. I will make the same change for a hotfix too

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client labels Nov 13, 2023
@seratch seratch added this to the 1.35.1 milestone Nov 13, 2023
@seratch seratch self-assigned this Nov 13, 2023
@codecov
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e9d7da) 74.04% compared to head (097e3fb) 74.04%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1234   +/-   ##
=========================================
  Coverage     74.04%   74.04%           
  Complexity     4083     4083           
=========================================
  Files           440      440           
  Lines         12995    12995           
  Branches       1310     1310           
=========================================
  Hits           9622     9622           
  Misses         2606     2606           
  Partials        767      767           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit 2ed8f7f into slackapi:main Nov 14, 2023
@seratch seratch deleted the issue-1233 branch November 14, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Class not found using FilesUploadV2Request.builder()

1 participant