Skip to content

fix: Empty user list for updating usergroup users sets usergroup as having no members#1574

Merged
vegeris merged 3 commits intoslackapi:mainfrom
rozza-sb:fix/empty_user_list_for_updating_usergroup_users_sets_group_as_having_no_members
Mar 31, 2026
Merged

fix: Empty user list for updating usergroup users sets usergroup as having no members#1574
vegeris merged 3 commits intoslackapi:mainfrom
rozza-sb:fix/empty_user_list_for_updating_usergroup_users_sets_group_as_having_no_members

Conversation

@rozza-sb
Copy link
Copy Markdown
Contributor

Currently when an empty list is provided within UsergroupsUsersUpdateRequest, it is sent in the request as users=, which is not supported by the Slack API to denote a usergroup as having 0 members. This adds a case for checking an empty list, and using the accepted value of [] in the request if so.

Fixes #1573.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@rozza-sb rozza-sb requested a review from a team as a code owner March 30, 2026 18:05
@salesforce-cla
Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @rozza-sb to sign the Salesforce Inc. Contributor License Agreement.

@vegeris
Copy link
Copy Markdown
Contributor

vegeris commented Mar 31, 2026

Thanks for updating this and adding tests!

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.20%. Comparing base (d9e6798) to head (69a6dba).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1574      +/-   ##
============================================
+ Coverage     73.17%   73.20%   +0.03%     
- Complexity     4510     4514       +4     
============================================
  Files           477      477              
  Lines         14283    14285       +2     
  Branches       1487     1488       +1     
============================================
+ Hits          10451    10458       +7     
+ Misses         2939     2936       -3     
+ Partials        893      891       -2     
Flag Coverage Δ
jdk-14 73.20% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vegeris vegeris merged commit 13f5c1b into slackapi:main Mar 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty users list in UsergroupsUsersUpdateRequest returns invalid_arguments

2 participants