Skip to content

Adjust html anchor to work with the fixed header#436

Merged
seratch merged 1 commit intoslackapi:masterfrom
seratch:link-anchor
Apr 19, 2020
Merged

Adjust html anchor to work with the fixed header#436
seratch merged 1 commit intoslackapi:masterfrom
seratch:link-anchor

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Apr 19, 2020

Summary

This pull request improves the document pages by adjusting HTML anchor positions. As a workaround, I needed to always place <hr/> in front of h2 tags to make this fix work.

Before

After

Requirements (place an x in each [ ])

@seratch seratch added the docs M-T: Documentation work only label Apr 19, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2020

Codecov Report

Merging #436 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #436      +/-   ##
============================================
- Coverage     83.94%   83.88%   -0.07%     
+ Complexity     2368     2367       -1     
============================================
  Files           249      249              
  Lines          6366     6366              
  Branches        578      578              
============================================
- Hits           5344     5340       -4     
- Misses          668      672       +4     
  Partials        354      354              
Impacted Files Coverage Δ Complexity Δ
...pi/methods/metrics/impl/RedisMetricsDatastore.java 87.03% <0.00%> (-2.47%) 37.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b00e32...08b5ca3. Read the comment docs.

@seratch seratch merged commit 721d1f3 into slackapi:master Apr 19, 2020
@seratch seratch deleted the link-anchor branch April 19, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant