Apply the changes detected by integration tests (2020-05-19, PT)#460
Merged
seratch merged 2 commits intoslackapi:masterfrom May 20, 2020
Merged
Apply the changes detected by integration tests (2020-05-19, PT)#460seratch merged 2 commits intoslackapi:masterfrom
seratch merged 2 commits intoslackapi:masterfrom
Conversation
1) Mark as_user parameter as deprecated for chat.postMessage calls (the server-side returns deprecation warnings to it when using it with bot tokens. 2) Add newly added fields in responses: message.root.parete_user_id, message.root.icons
seratch
added
project:slack-api-client
seratch
commented
May 20, 2020
| .threadTs(firstMessageCreation.getTs()) | ||
| ); | ||
| assertThat(reply1.getError(), is("invalid_arguments")); | ||
| assertThat(reply1.getDeprecatedArgument(), is("as_user")); |
Contributor
Author
There was a problem hiding this comment.
This error response indicates that as_user won't be available for any cases. If a Slack app needs to post a message on behalf of a user, the app can use the person's user token, not a bot token.
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=========================================
Coverage 83.65% 83.65%
Complexity 2387 2387
=========================================
Files 250 250
Lines 6442 6442
Branches 590 590
=========================================
Hits 5389 5389
Misses 690 690
Partials 363 363
Continue to review full report at Codecov.
|
seratch
commented
May 20, 2020
| "team_id": "T00000000", | ||
| "enterprise_id": "E00000000", | ||
| "api_app_id": "A00000000", | ||
| "team_id": "", |
Contributor
Author
There was a problem hiding this comment.
This used to be relying on my local assets. Now everyone can generate the same sample JSON files if they properly set up test workspaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Most parts in this pull request are test code updates but this is going to apply some changes to library code as below:
Requirements (place an
xin each[ ])