Skip to content

Add confirm.style in blocks#470

Merged
seratch merged 3 commits intoslackapi:masterfrom
seratch:confirm-style
May 27, 2020
Merged

Add confirm.style in blocks#470
seratch merged 3 commits intoslackapi:masterfrom
seratch:confirm-style

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented May 23, 2020

Summary

This pull request adds style to confirm composition objects in Block Kit.
https://api.slack.com/reference/block-kit/composition-objects#confirm

Related issues/changes:

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model labels May 23, 2020
@seratch seratch added this to the 1.0.x milestone May 23, 2020
@seratch seratch requested a review from stevengill May 23, 2020 02:57
@seratch seratch self-assigned this May 23, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2020

Codecov Report

Merging #470 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #470      +/-   ##
============================================
- Coverage     83.65%   83.59%   -0.07%     
+ Complexity     2387     2386       -1     
============================================
  Files           250      250              
  Lines          6442     6442              
  Branches        590      590              
============================================
- Hits           5389     5385       -4     
- Misses          690      694       +4     
  Partials        363      363              
Impacted Files Coverage Δ Complexity Δ
...pi/methods/metrics/impl/RedisMetricsDatastore.java 87.03% <0.00%> (-2.47%) 37.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53b1e4...9d99340. Read the comment docs.

Copy link
Copy Markdown
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seratch seratch merged commit 1a83033 into slackapi:master May 27, 2020
@seratch seratch deleted the confirm-style branch May 27, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants