-
Notifications
You must be signed in to change notification settings - Fork 228
Fix #773 Add Slack Connect API/Event supports #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #813 +/- ##
============================================
+ Coverage 77.06% 77.16% +0.09%
- Complexity 3401 3435 +34
============================================
Files 380 384 +4
Lines 10230 10291 +61
Branches 1000 1002 +2
============================================
+ Hits 7884 7941 +57
- Misses 1762 1764 +2
- Partials 584 586 +2
Continue to review full report at Codecov.
|
| }, | ||
| "link": "https://www.example.com/", | ||
| "recipient_user_id": "U00000000", | ||
| "recipient_email": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not exist in the document
| } | ||
| ], | ||
| "response_metadata": { | ||
| "next_cursor": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for pagination
srajiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one question for my knowledge, but this looks good to me!
| "invite_id": "I00000000", | ||
| "conf_code": "", | ||
| "is_legacy_shared_channel": false, | ||
| "needed": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When are the needed and provided fields returned by the API or they a feature of the java-sdk impl? I tried playing around with the api methods tester to generate these fields, but I didn't see these returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srajiang They can be returned when your app does not sufficient scopes for an API call. The fields are defined for all the response types in this SDK:
This pull request resolves #773 by adding Slack Connect APIs / events to this SDK. Refer to the document for more details: https://api.slack.com/apis/connect
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.