Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Aug 16, 2021

This pull request resolves #773 by adding Slack Connect APIs / events to this SDK. Refer to the document for more details: https://api.slack.com/apis/connect

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model project:slack-app-backend labels Aug 16, 2021
@seratch seratch added this to the 1.11.0 milestone Aug 16, 2021
@seratch seratch requested a review from srajiang August 16, 2021 06:14
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #813 (34a7483) into main (fbed1a4) will increase coverage by 0.09%.
The diff coverage is 93.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #813      +/-   ##
============================================
+ Coverage     77.06%   77.16%   +0.09%     
- Complexity     3401     3435      +34     
============================================
  Files           380      384       +4     
  Lines         10230    10291      +61     
  Branches       1000     1002       +2     
============================================
+ Hits           7884     7941      +57     
- Misses         1762     1764       +2     
- Partials        584      586       +2     
Impacted Files Coverage Δ
...java/com/slack/api/methods/RequestFormBuilder.java 89.22% <85.71%> (-0.08%) ⬇️
.../java/com/slack/api/methods/MethodsRateLimits.java 98.50% <100.00%> (+0.03%) ⬆️
...slack/api/methods/impl/AsyncMethodsClientImpl.java 92.92% <100.00%> (+0.17%) ⬆️
.../com/slack/api/methods/impl/MethodsClientImpl.java 84.67% <100.00%> (+0.21%) ⬆️
...ts/handler/SharedChannelInviteAcceptedHandler.java 100.00% <100.00%> (ø)
...ts/handler/SharedChannelInviteApprovedHandler.java 100.00% <100.00%> (ø)
...ts/handler/SharedChannelInviteDeclinedHandler.java 100.00% <100.00%> (ø)
...ts/handler/SharedChannelInviteReceivedHandler.java 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbed1a4...34a7483. Read the comment docs.

},
"link": "https://www.example.com/",
"recipient_user_id": "U00000000",
"recipient_email": ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not exist in the document

}
],
"response_metadata": {
"next_cursor": "",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for pagination

Copy link
Contributor

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one question for my knowledge, but this looks good to me!

"invite_id": "I00000000",
"conf_code": "",
"is_legacy_shared_channel": false,
"needed": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When are the needed and provided fields returned by the API or they a feature of the java-sdk impl? I tried playing around with the api methods tester to generate these fields, but I didn't see these returned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seratch seratch merged commit 2cbd9a3 into slackapi:main Aug 16, 2021
@seratch seratch deleted the issue-773-slack-connect-apis branch August 16, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model project:slack-app-backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slack Connect API / Events support

2 participants