Skip to content

Fix #945 Log level for rate-limited error logging #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 1 commit into from
Mar 3, 2022
Merged

Fix #945 Log level for rate-limited error logging #946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion slack-api-client/src/main/java/com/slack/api/methods/impl/AsyncRateLimitExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@ private static <T extends SlackApiTextResponse> T handleIOException(String teamI
private static void logSlackApiException(String teamId, String methodName, SlackApiException e) {
if (e.getResponse().code() == 429) {
String retryAfterSeconds = e.getResponse().header("Retry-After");
log.error("Got a rate-limited response from {} API (team: {}, error: {}, retry-after: {})",
// As long as you use this executor, the API client automatically retries the same request for you
log.warn("Got a rate-limited response from {} API (team: {}, error: {}, retry-after: {})",
methodName,
teamId,
e.getMessage(),
Expand Down