Fix #954 Add setToken(String) to MethodsClient request Interface #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
6 tasks
seratch
commented
Mar 27, 2022
| " \"user_id\": \"U1234567\",\n" + | ||
| " \"bot_id\": \"B12345678\",\n" + | ||
| " \"enterprise_id\": \"E12345678\",\n" + | ||
| " \"error\": \"\"\n" + |
Contributor
Author
There was a problem hiding this comment.
This had been wrong and the empty string value is unused in the existing tests.
slack-api-client/src/main/java/com/slack/api/methods/SlackApiRequest.java
Outdated
Show resolved
Hide resolved
slack-api-client/src/main/java/com/slack/api/methods/SlackApiRequest.java
Show resolved
Hide resolved
slack-api-client/src/test/java/test_locally/api/methods/SlackApiRequestTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #957 +/- ##
============================================
- Coverage 76.42% 76.42% -0.01%
- Complexity 3657 3658 +1
============================================
Files 396 397 +1
Lines 11056 11057 +1
Branches 1096 1096
============================================
Hits 8450 8450
Misses 1956 1956
- Partials 650 651 +1
Continue to review full report at Codecov.
|
seratch
commented
Mar 27, 2022
slack-api-client/src/test/java/test_locally/api/methods/SlackApiRequestTest.java
Outdated
Show resolved
Hide resolved
…piRequestTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #954
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.