Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented May 8, 2022

This pull request adds three new events:

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-app-backend labels May 8, 2022
@seratch seratch added this to the 1.22.1 milestone May 8, 2022
@seratch seratch self-assigned this May 8, 2022
@seratch seratch force-pushed the user-changed-events branch from ae92c30 to 0f94fee Compare May 9, 2022 00:01
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #984 (af2f93d) into main (aea01bb) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head af2f93d differs from pull request most recent head fface80. Consider uploading reports for the commit fface80 to get more accurate results

@@             Coverage Diff              @@
##               main     #984      +/-   ##
============================================
+ Coverage     76.87%   76.92%   +0.04%     
- Complexity     3677     3684       +7     
============================================
  Files           400      403       +3     
  Lines         11089    11095       +6     
  Branches       1105     1105              
============================================
+ Hits           8525     8535      +10     
+ Misses         1895     1890       -5     
- Partials        669      670       +1     
Impacted Files Coverage Δ
...ckend/events/handler/UserHuddleChangedHandler.java 100.00% <100.00%> (ø)
...kend/events/handler/UserProfileChangedHandler.java 100.00% <100.00%> (ø)
...ckend/events/handler/UserStatusChangedHandler.java 100.00% <100.00%> (ø)
...va/com/slack/api/socket_mode/SocketModeClient.java 68.15% <0.00%> (+0.63%) ⬆️
...i/socket_mode/impl/SocketModeClientJavaWSImpl.java 68.42% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea01bb...fface80. Read the comment docs.

@seratch seratch force-pushed the user-changed-events branch from 0f94fee to af2f93d Compare May 9, 2022 01:58
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @seratch! I've left a minor suggestion on a comment change, otherwise looks greats!

…ddleChangedEvent.java

Co-authored-by: Michael Brooks <michael@michaelbrooks.ca>
@seratch seratch merged commit c575ba4 into slackapi:main May 9, 2022
@seratch seratch deleted the user-changed-events branch May 9, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-app-backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants