Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Jun 17, 2022

This pull request fixes a bug on DetailedLoggingListener behavior. If I remember correctly, the logging listener used to work properly with older versions of okhttp but not it sometimes does not work. This pull request refactors the internals to make it function again. This PR does not bring any breaking changes to existing public classes / interfaces. Thus, we can ship it in the next patch version.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client labels Jun 17, 2022
@seratch seratch added this to the 1.22.3 milestone Jun 17, 2022
@seratch seratch self-assigned this Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #999 (22f49c6) into main (ec509ad) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #999      +/-   ##
============================================
+ Coverage     76.70%   76.79%   +0.08%     
- Complexity     3677     3684       +7     
============================================
  Files           403      403              
  Lines         11102    11103       +1     
  Branches       1109     1106       -3     
============================================
+ Hits           8516     8526      +10     
+ Misses         1909     1905       -4     
+ Partials        677      672       -5     
Impacted Files Coverage Δ
.../com/slack/api/methods/impl/MethodsClientImpl.java 85.07% <100.00%> (+0.01%) ⬆️
.../java/com/slack/api/util/http/SlackHttpClient.java 86.95% <100.00%> (+0.19%) ⬆️
...pi/util/http/listener/DetailedLoggingListener.java 79.59% <100.00%> (+7.36%) ⬆️
...k/api/util/http/listener/HttpResponseListener.java 100.00% <100.00%> (ø)
...java/com/slack/api/methods/RequestFormBuilder.java 88.25% <0.00%> (+<0.01%) ⬆️
...va/com/slack/api/socket_mode/SocketModeClient.java 68.15% <0.00%> (+0.63%) ⬆️
...imits/metrics/impl/BaseMemoryMetricsDatastore.java 80.08% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec509ad...22f49c6. Read the comment docs.

@seratch seratch merged commit 7ac5484 into slackapi:main Jun 17, 2022
@seratch seratch deleted the detailed-logging-listener-bug branch June 17, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant