Use Readable instead of ReadStream in uploadV2#1577
Merged
filmaj merged 1 commit intoslackapi:mainfrom Feb 1, 2023
Merged
Conversation
7 tasks
seratch
approved these changes
Feb 1, 2023
filmaj
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The old
uploadmethod accepts aReadablefor its file argument, but the newuploadV2accepts aReadStream. There is no reason to useReadStreamhere:Readableis strictly more generic (it's a superclass ofReadStream) and the code actually does not use any functionality specific toReadStream, it only uses methods and events fromReadable. This will make the transition fromuploadtouploadV2more easy.Requirements (place an
xin each[ ])