ci: simplify test scripts and separate coverage from test runs#2566
ci: simplify test scripts and separate coverage from test runs#2566WilliamBergamin merged 13 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: a8fa914 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
=======================================
Coverage 87.38% 87.38%
=======================================
Files 62 62
Lines 10256 10256
Branches 415 415
=======================================
Hits 8962 8962
Misses 1273 1273
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin Amazing improvements to CI health! I like the pattern of checking coverage for the latest version so much 🧪 ✨
I'm approving with a few notes and question about dependencies noted? If this all seems expected please do merge:
Added glob-bin as a root devDependency to replace bash -O globstar glob expansion in test scripts (cross-platform compatibility on Windows CI).
I added af3165f during review that hinted toward this package, but was this still used?
🚢 💨
There was a problem hiding this comment.
🔭 note: I'm so curious for what happens to this file in upcoming releases!
There was a problem hiding this comment.
Same! originally I thought of adding a patch to each package but that would be inaccurate because this does not actually have any effect on what the user consumes
| pull_request: | ||
|
|
||
| env: | ||
| LATEST_SUPPORTED_NODE: "24.x" |
There was a problem hiding this comment.
🧠 praise: Super nice to surface this clear!
| "lint": "npx @biomejs/biome check packages", | ||
| "lint:fix": "npx @biomejs/biome check --write packages", | ||
| "test": "npm test --workspaces --if-present", | ||
| "test:coverage": "npm run test:coverage --workspaces --if-present", |
There was a problem hiding this comment.
🏆 praise: These patterns are joined well here!
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
…e-slack-sdk into simplify-ci-testing
Summary
testscript and atest:coveragescript. Previously most packages aliased test to test:unit which always included coverage instrumentation.Requirements