Skip to content

Conversation

@artoonie
Copy link
Contributor

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

e.g. Fix bug for requests with a 'file' argument. The current code assumes 'file' is always a file's content (upload), whereas there are many requests that take a fileID with the argument name 'file'.

Related Issues

N/A (that I have found)

Test strategy

e.g. Test files.info in addition to the files.upload test that already exists.

Armin Samii added 2 commits August 24, 2016 15:40
For example, an API call to files.info takes a file ID argument named
"file", which was stripped out by this call. Currently, there is only
one request type that accepts file data (files.upload). Every other use
of 'file' is an ID that aught to be contained in the request.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 61.328% when pulling ea6f490 on artoonie:bugfix/file-info into 7dfa7f3 on slackhq:master.

@coveralls
Copy link

coveralls commented Aug 24, 2016

Coverage Status

Coverage increased (+0.5%) to 61.719% when pulling ea6f490 on artoonie:bugfix/file-info into 7dfa7f3 on slackhq:master.

@artoonie
Copy link
Contributor Author

Not sure why coveralls is failing on the py35 build...is this normal? Locally, I get the same issue on master.

@jammons
Copy link
Contributor

jammons commented Aug 31, 2016

This looks good. Thanks!

I just retriggered the test run and it passed (I don't know why that happens, but it does sometimes).

@jammons jammons merged commit 8353fa2 into slackapi:master Aug 31, 2016
@artoonie artoonie deleted the bugfix/file-info branch August 31, 2016 21:55
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
Fix bug: requests with a 'file' argument work now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants