Recommend using the files_upload_v2 method for uploading files#1402
Merged
seratch merged 1 commit intoslackapi:mainfrom Sep 16, 2023
Merged
Recommend using the files_upload_v2 method for uploading files#1402seratch merged 1 commit intoslackapi:mainfrom
files_upload_v2 method for uploading files#1402seratch merged 1 commit intoslackapi:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
+ Coverage 85.37% 85.40% +0.03%
==========================================
Files 111 111
Lines 11860 11860
==========================================
+ Hits 10125 10129 +4
+ Misses 1735 1731 -4 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the example in the README to recommend using
files_upload_v2for uploading files to avoid warnings raised by the currentfiles_uploadmethod.Notes
Unsure if linking to the release notes for
files_upload_v2is alright (instead of API documentation) since there are multiple API methods being called now. These release notes do a great job of documenting this method though, so I think this might be helpful!Category
/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.