Skip to content

fix: improve Socket Mode client stability and correctness #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 3 commits into from
Apr 10, 2026

Make it work with magic mock

2787042
Select commit
Loading
Failed to load commit list.
Merged

fix: improve Socket Mode client stability and correctness #1854

Make it work with magic mock
2787042
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 10, 2026 in 0s

84.01% (+0.01%) compared to 067560a

View this Pull Request on Codecov

84.01% (+0.01%) compared to 067560a

Details

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.01%. Comparing base (067560a) to head (2787042).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
slack_sdk/socket_mode/builtin/internals.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1854      +/-   ##
==========================================
+ Coverage   83.99%   84.01%   +0.01%     
==========================================
  Files         117      117              
  Lines       13253    13256       +3     
==========================================
+ Hits        11132    11137       +5     
+ Misses       2121     2119       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov