Skip to content

fix: pin cryptography<46 for PyPy 3.10 CI builds#1860

Merged
WilliamBergamin merged 1 commit intomainfrom
fix-pypy310-cryptography-ci
Apr 27, 2026
Merged

fix: pin cryptography<46 for PyPy 3.10 CI builds#1860
WilliamBergamin merged 1 commit intomainfrom
fix-pypy310-cryptography-ci

Conversation

@WilliamBergamin
Copy link
Copy Markdown
Contributor

Summary

These changes aim to fix the CI by pinning cryptography<46 for PyPy 3.10 via environment markers

  • cryptography 46+ uses PyO3 0.27+, which dropped PyPy 3.10 support, causing the source build to fail with: error: the configured PyPy interpreter version (3.10) is lower than PyO3's minimum supported version (3.11)
  • cryptography 45.0.x is the last version with pre-built PyPy 3.10 wheels

Testing

CI tests should be sufficient

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@WilliamBergamin WilliamBergamin added this to the 3.41.1 milestone Apr 27, 2026
@WilliamBergamin WilliamBergamin self-assigned this Apr 27, 2026
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner April 27, 2026 15:27
@WilliamBergamin WilliamBergamin added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch labels Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.01%. Comparing base (aa3a16d) to head (6c53691).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1860   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files         117      117           
  Lines       13256    13256           
=======================================
  Hits        11137    11137           
  Misses       2119     2119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@srtaalej srtaalej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating this!

@WilliamBergamin WilliamBergamin enabled auto-merge (squash) April 27, 2026 16:15
@WilliamBergamin WilliamBergamin merged commit 9435412 into main Apr 27, 2026
17 checks passed
@WilliamBergamin WilliamBergamin deleted the fix-pypy310-cryptography-ci branch April 27, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants