Skip to content

Fix #690 by adding basic auth handling in the new sync client#691

Merged
seratch merged 1 commit intoslackapi:masterfrom
seratch:fix-issue-690
May 19, 2020
Merged

Fix #690 by adding basic auth handling in the new sync client#691
seratch merged 1 commit intoslackapi:masterfrom
seratch:fix-issue-690

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented May 19, 2020

Summary

This pull request fixes #690 by resolving the lack of basic auth header generation when run_async=False. This lack of implementation used to result in oauth.v2.access and oauth.access API call failures.

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client v2.6 in-progress labels May 19, 2020
@seratch seratch added this to the 2.6.0 milestone May 19, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2020

Codecov Report

Merging #691 into master will increase coverage by 0.19%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   85.40%   85.59%   +0.19%     
==========================================
  Files          19       19              
  Lines        2624     2631       +7     
  Branches      249      252       +3     
==========================================
+ Hits         2241     2252      +11     
+ Misses        289      285       -4     
  Partials       94       94              
Impacted Files Coverage Δ
slack/web/base_client.py 75.88% <42.85%> (+0.61%) ⬆️
slack/web/client.py 95.29% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cc4d8...6a3a607. Read the comment docs.

@seratch seratch merged commit b240dd7 into slackapi:master May 19, 2020
@seratch seratch deleted the fix-issue-690 branch May 19, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.6.0rc1 invalid_client_id

1 participant