Fix #690 by adding basic auth handling in the new sync client#691
Merged
seratch merged 1 commit intoslackapi:masterfrom May 19, 2020
Merged
Fix #690 by adding basic auth handling in the new sync client#691seratch merged 1 commit intoslackapi:masterfrom
seratch merged 1 commit intoslackapi:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
==========================================
+ Coverage 85.40% 85.59% +0.19%
==========================================
Files 19 19
Lines 2624 2631 +7
Branches 249 252 +3
==========================================
+ Hits 2241 2252 +11
+ Misses 289 285 -4
Partials 94 94
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #690 by resolving the lack of basic auth header generation when
run_async=False. This lack of implementation used to result inoauth.v2.accessandoauth.accessAPI call failures.Requirements (place an
xin each[ ])