Correct Block.parse(dict) to support CallBlock#775
Merged
seratch merged 2 commits intoslackapi:mainfrom Aug 6, 2020
Merged
Conversation
seratch
added
Version: 2x
bug
Codecov Report
@@ Coverage Diff @@
## main #775 +/- ##
==========================================
+ Coverage 87.30% 87.36% +0.06%
==========================================
Files 30 30
Lines 3600 3602 +2
Branches 317 318 +1
==========================================
+ Hits 3143 3147 +4
+ Misses 324 323 -1
+ Partials 133 132 -1
Continue to review full report at Codecov.
|
stevengill
approved these changes
Aug 6, 2020
mwbrooks
added a commit
that referenced
this pull request
Aug 6, 2020
- See #775 where Block.parse coverage is added for other blocks
2 tasks
seratch
pushed a commit
that referenced
this pull request
Aug 6, 2020
mwbrooks
approved these changes
Aug 6, 2020
seratch
pushed a commit
that referenced
this pull request
Aug 6, 2020
seratch
added a commit
that referenced
this pull request
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While reviewing #768 , I found that
CallBlockis not yet supported inBlock.parse(dict)method. The block class was introduced by #704. I missed changing the class method in the PR.Requirements (place an
xin each[ ])