fix: URL checker uses HEAD instead of GET

[mwbrooks]

CHANGELOG

Fix a bug to allow new projects to be created quicker by using a HTTP HEAD request to check if the template URL exists.

Summary

This pull request updates the URLChecker(http, url) to check if the URL exists using a HEAD request instead of a GET request. This should improve performance, since it will not download the zip to only confirm that the URL is valid.

There should be no change to functionality.

Reviewers

$ lack create asdf
# → Select any app, since all apps are downloaded from template URLS
# → Confirm that the app is created

# Cleanup
$ rm -rf asdf/

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.06%. Comparing base (fcb3cde) to head (ba86f97).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   63.06%   63.06%           
=======================================
  Files         212      212           
  Lines       21672    21672           
=======================================
  Hits        13668    13668           
  Misses       6951     6951           
  Partials     1053     1053           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zimeg]

@mwbrooks Super nice find! I'm so glad we're enhancing the slackhttp package with these changes 🎁 ✨

LGTM and testing works well without git available:

$ PATH="" ./bin/slack create -t slack-samples/bolt-js-starter-template
...
📋 Next steps to begin development
   Change into your project with cd jolly-koala-551/

$ PATH="" ./bin/slack create -t slack-samples/bolt-unknown-starter-app
...
🚫 Cannot download Git repository as a .zip archive (git_zip_download_error)

📬 suggestion(non-blocking): Updating the error message to git_repo_not_found or with similar messaging might be interesting!

🚢 note: Please feel free to merge this when the time is right!

[mwbrooks]

Thanks for the quick review @zimeg!

📬 suggestion(non-blocking): Updating the error message to git_repo_not_found or with similar messaging might be interesting!

Interesting suggestion! This error is actually coming from the caller of URLChecker(http, url) so let's hold off and change that error code in another PR so it appears as a separate CHANGELOG entry. 📝