feat: remove deno from installation scripts by zimeg · Pull Request #189 · slackapi/slack-cli

zimeg · 2025-08-12T07:14:43Z

Changelog

The deno runtime is no longer installed with the installation script. We recommend installing deno separately and configuring CI systems as needed for app development (such as for ROSI apps).

Summary

This PR removes deno from the installation scripts for improved bolt support. Also included are tests for the unix installation scripts in CI.

Preview

install.mov

Reviewers

🦕 An upstream version can be downloaded with these commands:

$ ./scripts/install.sh lack-dev

> .\scripts\install-windows.ps1

Notes

Updates to the installation docs ought be with this changeset! 📚 ✨

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

…stall

codecov · 2025-08-12T07:16:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.95%. Comparing base (9239803) to head (83a8f82).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   62.97%   62.95%   -0.03%     
==========================================
  Files         212      212              
  Lines       21782    21782              
==========================================
- Hits        13718    13713       -5     
- Misses       7003     7006       +3     
- Partials     1061     1063       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ng in another pr

…another pr

…leshootings

…rors

zimeg · 2025-08-20T19:46:29Z

🗣️ The "Lints and Unit tests" check is pending because this workflow name was changed to "Lints and Tests" in this PR. Before merging we can update the required checks if that's alright!

WilliamBergamin

Nice job 🚀 I don't have much to add, we can always fix forward

WilliamBergamin · 2025-08-20T19:54:01Z

docs/guides/installing-the-slack-cli-for-mac-and-linux.md

+- [Bolt for JavaScript](/tools/bolt-js/getting-started)
+- [Bolt for Python](/tools/bolt-python/getting-started)
+- [Deno Slack SDK](/tools/deno-slack-sdk/guides/getting-started)


Praise 🙏

WilliamBergamin · 2025-08-20T19:58:42Z

scripts/install-windows-dev.ps1

+    Write-Host "`nUse of the Slack CLI should comply with the Slack API Terms of Service:"
+    Write-Host "   https://slack.com/terms-of-service/api"


WilliamBergamin · 2025-08-20T19:59:52Z

scripts/install.sh

+                fi
+                ;;
+        *)
+                >&2 echo -e "\x1b[1m⚠️  Warning: An unknown flag '$1' was passed to the Slack CLI installation script!\x1b[0m"


Praise the user experience improvement 🙏

WilliamBergamin · 2025-08-20T20:01:14Z

scripts/install.sh

        delay 0.2 "💾 Successfully downloaded Slack CLI v$LATEST_SLACK_CLI_VERSION to $(home_path "$slack_cli_install_dir/slack-cli.tar.gz")"

-        delay 0.3 "📦 Extracting the Slack CLI command binary to $(home_path $slack_cli_bin_path)"
+        delay 0.3 "📦 Extracting the Slack CLI command binary to $(home_path "$slack_cli_bin_path")"


WilliamBergamin · 2025-08-20T20:02:28Z

scripts/install.sh

+        sleep 0.1
+        feedback_message


Out of scope, but is there a way to toggle these sleep off to improve the CI experience?

I don't believe so right now, but this is a good idea to follow up on 🙏

IIRC we've discussed environment variable options but I forget at the moment if we settled on something? I'll also be thinking about this!

zimeg

@WilliamBergamin Thanks for the kind review! I'm hoping to merge this for next release but will hold off right now.

Also - huge thanks to @lukegalbraithrussell for the branch previews - I left a few comments below to make sure links follow as expected 👁️‍🗨️

zimeg · 2025-08-21T00:01:35Z

docs/guides/installing-the-slack-cli-for-mac-and-linux.md

📚 Preview

zimeg · 2025-08-21T00:01:56Z

docs/guides/installing-the-slack-cli-for-windows.md

📚 Preview

zimeg · 2025-08-21T00:08:48Z

scripts/install.sh

+        sleep 0.1
+        feedback_message


I don't believe so right now, but this is a good idea to follow up on 🙏

IIRC we've discussed environment variable options but I forget at the moment if we settled on something? I'll also be thinking about this!

docs/guides/installing-the-slack-cli-for-mac-and-linux.md

lukegalbraithrussell · 2025-08-21T00:12:46Z

docs/guides/installing-the-slack-cli-for-mac-and-linux.md

+
+The automated installer attempts to add the Slack CLI to a known directory in the path: `/usr/local/bin`.
+
+Some machines protect this directory and elevated access might be needed for updated permissions. We do not recommend using `sudo` with the automated installer since unexpected side effects might place downloads in the wrong spot.


i'll sudo if i want to!

sudo or bust

docs/guides/installing-the-slack-cli-for-windows.md

lukegalbraithrussell

nits of words but docs look good both here and on the preview!

Co-authored-by: Luke Russell <31357343+lukegalbraithrussell@users.noreply.github.com>

zimeg

@lukegalbraithrussell I appreciate the review!

I'm going to keep reading the docs and might land a few small changes but will hold off on merging this for the moment 🫡

docs/guides/installing-the-slack-cli-for-windows.md

docs/guides/authorizing-the-slack-cli.md

Co-authored-by: Haley Elmendorf <31392893+haleychaas@users.noreply.github.com>

zimeg · 2025-08-21T23:22:18Z

@WilliamBergamin @lukegalbraithrussell @haleychaas Thank y'all for the reviews in this change 🙏 ✨

Now is seeming like an alright time to merge this, so let's! I am wondering if we want to avoid publishing the docs updates for now but will open discussion on this elsewhere 🤖

I've also made a note about the faster CI improvements to follow for this script, and am hoping we can continue follow ups of that and #188 soon! 🚢

Marking the calendar to publish these scripts on September 1 upcoming 📆 👾

zimeg · 2025-08-22T23:00:43Z

🗣️ The changes of this PR are unrelated to CLI command behavior and are scheduled to be uploaded separate of when this release goes public IIRC.

Changing it to a semver:patch for this upcoming release!

mwbrooks · 2025-09-03T02:56:25Z

.github/workflows/tests.yml

 jobs:
  lint-test:
-    name: Lints and Unit tests
+    name: Lints and Tests


❤️ Details!

@mwbrooks I'm so glad we're testing installation scripts here now too! It might be excessive since even unrelated changes exercise this, but I like that the confidence it brings 🤖 ✨

zimeg and others added 7 commits August 11, 2025 21:49

feat: install to $HOME/.local/bin if writes to /usr/local/bin fail

d1ebca2

feat: swap order of feedback message in windows installation scripts

02ccf54

fix: return newline before warning

3d6f561

refactor: match order of install outputs and functions for windows in…

5d66226

…stall

feat: remove deno from installation scripts

641fbca

test: confirm installation scripts install the slack cli

423626e

fix: remove a trailing comma from powershell script arguments

72ab98c

zimeg added this to the Next Release milestone Aug 12, 2025

zimeg self-assigned this Aug 12, 2025

zimeg added enhancement M-T: A feature request for new functionality code health M-T: Test improvements and anything that improves code health semver:minor Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Aug 12, 2025

style: match github workflow names

c195a8d

zimeg added the changelog Use on updates to be included in the release notes label Aug 12, 2025

zimeg added 2 commits August 12, 2025 13:23

docs: troublshooting steps with local bin symbolic link setups

ea69a4a

chore: merge w basebranch

a68f6f1

zimeg changed the base branch from zimeg-feat-install-local-bin to main August 20, 2025 17:20

zimeg added 5 commits August 20, 2025 10:34

chore: merge w main

287b5e7

revert: keep doc changes for installation fallbacks and torubleshooti…

1520dd0

…ng in another pr

revert: keep local bin installation fallbacks and torubleshooting in …

bd6ba61

…another pr

docs: remove deno installation from install pages and rearrange troub…

482b2db

…leshootings

revert: remove install test from circleci runner due to permission er…

6001989

…rors

zimeg mentioned this pull request Aug 20, 2025

feat: install to $HOME/.local/bin if writes to /usr/local/bin fail #188

Merged

2 tasks

zimeg marked this pull request as ready for review August 20, 2025 19:47

zimeg requested review from a team as code owners August 20, 2025 19:47

zimeg requested a review from WilliamBergamin August 20, 2025 19:47

zimeg added the docs M-T: Documentation work only label Aug 20, 2025

WilliamBergamin approved these changes Aug 20, 2025

View reviewed changes

zimeg commented Aug 21, 2025

View reviewed changes

lukegalbraithrussell reviewed Aug 21, 2025

View reviewed changes

docs/guides/installing-the-slack-cli-for-mac-and-linux.md Outdated Show resolved Hide resolved

lukegalbraithrussell reviewed Aug 21, 2025

View reviewed changes

docs/guides/installing-the-slack-cli-for-windows.md Outdated Show resolved Hide resolved

lukegalbraithrussell reviewed Aug 21, 2025

View reviewed changes

docs/guides/installing-the-slack-cli-for-windows.md Outdated Show resolved Hide resolved

lukegalbraithrussell approved these changes Aug 21, 2025

View reviewed changes

zimeg and others added 2 commits August 20, 2025 17:24

docs: words of convincing reason to use this cli

f9b8b56

Co-authored-by: Luke Russell <31357343+lukegalbraithrussell@users.noreply.github.com>

docs: describe what a flag does

72ccb6d

Co-authored-by: Luke Russell <31357343+lukegalbraithrussell@users.noreply.github.com>

zimeg commented Aug 21, 2025

View reviewed changes

docs/guides/installing-the-slack-cli-for-windows.md Outdated Show resolved Hide resolved

zimeg added 4 commits August 20, 2025 17:36

docs: authorize next steps to bolt and workflow apps

dab3956

docs: infinite inline of paragraphs

16678ba

docs: explain the skip git windows install option example

0b74908

docs: match optional casing in reference

52a28f4

haleychaas reviewed Aug 21, 2025

View reviewed changes

docs/guides/authorizing-the-slack-cli.md Outdated Show resolved Hide resolved

zimeg and others added 2 commits August 21, 2025 16:07

docs: reference apps built with the deno slack sdk as so

33f967a

Co-authored-by: Haley Elmendorf <31392893+haleychaas@users.noreply.github.com>

fix: exit from installation script if invalid semversion is used

83a8f82

zimeg merged commit 5033493 into main Aug 21, 2025
6 checks passed

zimeg deleted the zimeg-feat-install-deno-remove branch August 21, 2025 23:22

zimeg added semver:patch Use on pull requests to describe the release version increment and removed semver:minor Use on pull requests to describe the release version increment labels Aug 22, 2025

mwbrooks reviewed Sep 3, 2025

View reviewed changes

		Write-Host "`nUse of the Slack CLI should comply with the Slack API Terms of Service:"
		Write-Host " https://slack.com/terms-of-service/api"


		The automated installer attempts to add the Slack CLI to a known directory in the path: `/usr/local/bin`.

		Some machines protect this directory and elevated access might be needed for updated permissions. We do not recommend using `sudo` with the automated installer since unexpected side effects might place downloads in the wrong spot.

Conversation

zimeg commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Summary

Preview

Reviewers

Notes

Requirements

Uh oh!

codecov bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zimeg commented Aug 20, 2025

Uh oh!

WilliamBergamin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lukegalbraithrussell left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zimeg commented Aug 21, 2025

Uh oh!

Uh oh!

zimeg commented Aug 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zimeg commented Aug 12, 2025 •

edited

Loading

codecov bot commented Aug 12, 2025 •

edited

Loading