-
Notifications
You must be signed in to change notification settings - Fork 24
docs(readme): Update CodeCov badge on README.md #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
==========================================
+ Coverage 62.81% 62.83% +0.02%
==========================================
Files 210 210
Lines 22053 22053
==========================================
+ Hits 13853 13858 +5
+ Misses 7122 7120 -2
+ Partials 1078 1075 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks once more for ordering and organizing these badges. A landing page can be more important than I'd thought 🎁
Approving now because this URL is working for me - the commit specific one doesn't? - but I'm hopeful main will work alright:
https://github.com/slackapi/slack-cli/blob/mbrooks-update-readme-codecov/README.md
👾
| [](https://github.com/slackapi/slack-cli/actions/workflows/tests.yml) | ||
| [](https://dl.circleci.com/status-badge/redirect/gh/slackapi/slack-cli/tree/main) | ||
| [](https://github.com/slackapi/slack-cli/actions/workflows/tests.yml) | ||
| [](https://codecov.io/gh/slackapi/slack-cli) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ Great catch with this updated token!
I hope this might be removed altogether in a future PR, but for now I'm finding this returns coverage reports 🤖 ✨
|
Edit: It might've been a caching thing! The URL you shared is loading for me now 😉 |
Summary
This pull request updates the token used by the codecov badge, so that it displays the correct code coverage report. It also reorders the badges to be: Tests, CodeCov, and then CircleCI
Reviewers
Requirements