Skip to content

Conversation

@mwbrooks
Copy link
Member

@mwbrooks mwbrooks commented Mar 31, 2025

Summary

This pull request updates the token used by the codecov badge, so that it displays the correct code coverage report. It also reorders the badges to be: Tests, CodeCov, and then CircleCI

Reviewers

Requirements

@mwbrooks mwbrooks added docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment labels Mar 31, 2025
@mwbrooks mwbrooks added this to the Next Release milestone Mar 31, 2025
@mwbrooks mwbrooks self-assigned this Mar 31, 2025
@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.83%. Comparing base (afa0d27) to head (1fd5243).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   62.81%   62.83%   +0.02%     
==========================================
  Files         210      210              
  Lines       22053    22053              
==========================================
+ Hits        13853    13858       +5     
+ Misses       7122     7120       -2     
+ Partials     1078     1075       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks marked this pull request as ready for review March 31, 2025 22:30
@mwbrooks mwbrooks requested a review from a team as a code owner March 31, 2025 22:30
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks once more for ordering and organizing these badges. A landing page can be more important than I'd thought 🎁

Approving now because this URL is working for me - the commit specific one doesn't? - but I'm hopeful main will work alright:

https://github.com/slackapi/slack-cli/blob/mbrooks-update-readme-codecov/README.md

👾

[![Tests](https://github.com/slackapi/slack-cli/actions/workflows/tests.yml/badge.svg?branch=main)](https://github.com/slackapi/slack-cli/actions/workflows/tests.yml)
[![CircleCI](https://dl.circleci.com/status-badge/img/gh/slackapi/slack-cli/tree/main.svg?style=svg&circle-token=CCIPRJ_TfxL4UXvmnaoZ6np7aRRsT_df235908b5a56f4206787b59c6fbee59490ac35d)](https://dl.circleci.com/status-badge/redirect/gh/slackapi/slack-cli/tree/main)
[![tests](https://github.com/slackapi/slack-cli/actions/workflows/tests.yml/badge.svg?branch=main)](https://github.com/slackapi/slack-cli/actions/workflows/tests.yml)
[![codecov](https://codecov.io/gh/slackapi/slack-cli/branch/main/graph/badge.svg?token=G5TU59IV9I)](https://codecov.io/gh/slackapi/slack-cli)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️‍🗨️ Great catch with this updated token!

I hope this might be removed altogether in a future PR, but for now I'm finding this returns coverage reports 🤖 ✨

@zimeg
Copy link
Member

zimeg commented Mar 31, 2025

Edit: It might've been a caching thing! The URL you shared is loading for me now 😉

@mwbrooks mwbrooks merged commit bb9a1f7 into main Mar 31, 2025
6 checks passed
@mwbrooks mwbrooks deleted the mbrooks-update-readme-codecov branch March 31, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants