Skip to content

ci(fix): add circleci pipeline definition to manual e2e tests#200

Merged
zimeg merged 2 commits intomainfrom
zimeg-ci-fix-circleci-definition-id
Sep 5, 2025
Merged

ci(fix): add circleci pipeline definition to manual e2e tests#200
zimeg merged 2 commits intomainfrom
zimeg-ci-fix-circleci-definition-id

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented Aug 18, 2025

Summary

This PR follows #196 and adds the CircleCI pipeline definition to manual E2E test inputs as an update to breaking changes.

Preview

Notes

🔗 Release notes: https://github.com/promiseofcake/circleci-trigger-action/releases/tag/v2.0.0

🔏 I added the CircleCI pipeline ID as CIRCLECI_DEFINITION_ID to the repo secret sto match documented examples!

Requirements

@zimeg zimeg added this to the Next Release milestone Aug 18, 2025
@zimeg zimeg requested a review from vegeris August 18, 2025 18:29
@zimeg zimeg self-assigned this Aug 18, 2025
@zimeg zimeg requested a review from a team as a code owner August 18, 2025 18:29
@zimeg zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Aug 18, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.96%. Comparing base (d2349b6) to head (2938551).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   62.95%   62.96%   +0.01%     
==========================================
  Files         212      212              
  Lines       21782    21782              
==========================================
+ Hits        13712    13715       +3     
+ Misses       7006     7005       -1     
+ Partials     1064     1062       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg zimeg modified the milestones: v3.6.1, Next Release Aug 22, 2025
Copy link
Copy Markdown
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 👌🏻 Looking good!

@zimeg
Copy link
Copy Markdown
Member Author

zimeg commented Sep 5, 2025

@mwbrooks A most kind thank you as always 🐢 ✨

@zimeg zimeg merged commit ff22405 into main Sep 5, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-ci-fix-circleci-definition-id branch September 5, 2025 17:36
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health and removed bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented build M-T: Changes to compilation and CI processes labels Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants